Skip to content

Add support for mmaped memory in crashdumps and guest debugging #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2025
Merged

Add support for mmaped memory in crashdumps and guest debugging #943

merged 2 commits into from
Oct 20, 2025

Conversation

@dblnz
Copy link
Contributor

@dblnz dblnz commented Oct 7, 2025

Fixes #747 and is a blocker for hyperlight-dev/hyperlight-wasm#129.

This modifies the guest debugging by adding a DebugMemoryAccess type that handles the memory access for the debugger. It abstracts over the type of memory, shared or mmaped.

Additionally, we now include the mmapped memory regions in the crashdump.

@dblnz dblnz added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Oct 7, 2025
@dblnz dblnz force-pushed the fix-dbg-mapped-memory branch from d463cbc to c6e40e2 Compare October 8, 2025 08:49
@dblnz dblnz marked this pull request as ready for review October 8, 2025 12:23
@dblnz dblnz added this to the v0.11.0 milestone Oct 8, 2025
@ludfjig
Copy link
Contributor

ludfjig commented Oct 10, 2025

This looks good to me, but it looks like we're circumventing our SharedMemory abstraction here with unsafe code like from_raw. Would it be possible to avoid this?

@dblnz
Copy link
Contributor Author

dblnz commented Oct 10, 2025 •
edited
Loading

That is true, but I think this is a consequence of how the mmapped memory is handled. As a separate set of regions.
What I think I could do is implement something similar to SharedMemory abstraction over the mmapped memory that keeps track of accessing and mapping/unmapping.

@ludfjig
Copy link
Contributor

ludfjig commented Oct 10, 2025

That is true, but I think this is a consequence of how the mmapped memory is handled. As a separate set of regions.
What I think I could do is implement something similar to SharedMemory abstraction over the mmapped memory that keeps track of accessing and mapping/unmapping.

Oh yeah forgot about that... That might be unfeasible

@dblnz dblnz force-pushed the fix-dbg-mapped-memory branch from c6e40e2 to d4fc726 Compare October 14, 2025 13:31
@dblnz
Copy link
Contributor Author

dblnz commented Oct 15, 2025

I believe this PR touches on the Sandbox memory model discussion we need to have, specifically about how mmaped memory should fit into it. This is tracked in #956 .

jsturtevant
jsturtevant previously approved these changes Oct 15, 2025
View reviewed changes
@simongdavies
Copy link
Contributor

That is true, but I think this is a consequence of how the mmapped memory is handled. As a separate set of regions.
What I think I could do is implement something similar to SharedMemory abstraction over the mmapped memory that keeps track of accessing and mapping/unmapping.

Oh yeah forgot about that... That might be unfeasible

I think we should go forward with this as is and then address the winder memory issues in #956

simongdavies
simongdavies previously approved these changes Oct 20, 2025
View reviewed changes
dblnz added 2 commits October 20, 2025 12:02
@dblnz
[dbg] Add debug support for memory mapped regions in Hypervisors
40d31d1 
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
@dblnz
[crashdump] Fix mmaped memory not included in dump
22ef548 
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
@dblnz dblnz dismissed stale reviews from simongdavies and jsturtevant via 22ef548 October 20, 2025 09:03
@dblnz dblnz force-pushed the fix-dbg-mapped-memory branch from d4fc726 to 22ef548 Compare October 20, 2025 09:03
@dblnz dblnz merged commit 7a26621 into hyperlight-dev:main Oct 20, 2025
49 checks passed
@dblnz dblnz self-assigned this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simongdavies simongdavies simongdavies approved these changes

@jsturtevant jsturtevant jsturtevant left review comments

@danbugs danbugs Awaiting requested review from danbugs danbugs is a code owner

@ludfjig ludfjig Awaiting requested review from ludfjig ludfjig is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

@jprendes jprendes Awaiting requested review from jprendes jprendes is a code owner

Assignees

@dblnz dblnz

Labels

kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.

Projects

None yet

Milestone

v0.11.0

Development

Successfully merging this pull request may close these issues.

Investigate make crashdump feature work with mmaped regions

4 participants

@dblnz @ludfjig @simongdavies @jsturtevant